Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] feat(Button): textClassName prop #6516

Merged
merged 4 commits into from
Nov 6, 2023
Merged

[core] feat(Button): textClassName prop #6516

merged 4 commits into from
Nov 6, 2023

Conversation

adidahiya
Copy link
Contributor

Fixes #4460, fixes #2207

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Add textClassName prop for Button and AnchorButton components
  • Demonstrate usage of this new prop in Select docs example
  • Add Select component documentation for displaying "placeholder" values in button text

Reviewers should focus on:

N/A

Screenshot

image

image

@adidahiya adidahiya mentioned this pull request Nov 6, 2023
Closed
@adidahiya
Copy link
Contributor Author

Need to omit this new prop from the DOM:

image

@adidahiya
Copy link
Contributor Author

omit new prop from DOM

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya enabled auto-merge (squash) November 6, 2023 15:56
@adidahiya adidahiya merged commit 3e28c88 into develop Nov 6, 2023
2 of 3 checks passed
@adidahiya adidahiya deleted the ad/select-placeholder-styling branch November 6, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

textClassName property for Button component Support empty default for dropdowns
1 participant
@adidahiya