chore: migrate to @twbs/fantasticon #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: migrate to @twbs/fantasticonBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Migrate from
fantasticonv1.x to@twbs/fantasticonv2.xPreviously, we were stuck on
fantasticonv1.x due to this bug. The Bootstrap team also avoided v2.x for the same reason. It appears that they have forked the project and have been steadily pushing updates in the@twbs/fantasticonpackage. It seems like a good option to keep our icon-related tooling up-to-date, sincefantasticonv1.x is not receiving any updates.Reviewers should focus on:
No regressions in icon rendering like #5074
Screenshot