Fix DateRangePicker3 bug when initialMonth is equal to the maxDate's month #6548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6546
The bug occurs when
initialMonthAndYear
is equal to themaxDate
's month and year resulting in a buggy selection state.We already handle this special case when using
props.initialMonth
orvalue[0]
as the initial month, this PR just expands the special case check to also include thetoday
anddateBetween
cases.Checklist
Changes proposed in this pull request:
Additionally checks that
today
ordateBetween
(if being used as initialMonth) is not the same month asmaxDate
s month and if it is use the previous monthReviewers should focus on:
Screenshot
Testing locally on the docs app setting the minDate as and
new Date(2023, 9, 23)
and maxDate asnew Date(2023, 10, 15)
before:
![Screenshot 2023-11-14 at 8 40 46 PM](https://private-user-images.githubusercontent.com/13280642/282977938-217726da-abfe-4196-99e3-128030157bc8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MDcwMDIsIm5iZiI6MTcyMTUwNjcwMiwicGF0aCI6Ii8xMzI4MDY0Mi8yODI5Nzc5MzgtMjE3NzI2ZGEtYWJmZS00MTk2LTk5ZTMtMTI4MDMwMTU3YmM4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIwMTgyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThjMjhjMGYzMzkzZjZiYTY5ODVjNjgxY2Q1M2VlYjEwNGFjNDMzZjE2MGViNDU3NmM4NGJmYTc3NzBlOWY0M2ImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WrHcY7z9wF4p4qJUAjs93-EAW41r5D03NTJfWKXixZM)
![Screenshot 2023-11-14 at 8 40 41 PM](https://private-user-images.githubusercontent.com/13280642/282977941-5fb33c37-6caa-4682-b63b-ca86124e3fdd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MDcwMDIsIm5iZiI6MTcyMTUwNjcwMiwicGF0aCI6Ii8xMzI4MDY0Mi8yODI5Nzc5NDEtNWZiMzNjMzctNmNhYS00NjgyLWI2M2ItY2E4NjEyNGUzZmRkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIwMTgyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIwZDVlM2JmYjQzOGViMTljYmZmYzY3ZmE5MGUzZGJjNTAwNzhiYmE0ODYyN2U2ZTg5NjdkYWVkNDk5MGQ3ZjgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.mGVh7RgcemgFmQBRga7iUCtCp62f0kLDeQpb2igI6RU)
after:
![Screenshot 2023-11-14 at 8 39 54 PM](https://private-user-images.githubusercontent.com/13280642/282977966-469c2d74-8244-4ea3-b2a3-e480b36a6402.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MDcwMDIsIm5iZiI6MTcyMTUwNjcwMiwicGF0aCI6Ii8xMzI4MDY0Mi8yODI5Nzc5NjYtNDY5YzJkNzQtODI0NC00ZWEzLWIyYTMtZTQ4MGIzNmE2NDAyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIwMTgyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM0ZmIzMjgwZmM2OTFlYjE3YTcwMTk4Mjc0OTdiNTRjMTNhYTMxMjMwYmM0MTNhZjQyMzczMDQ5ZjkyMTdhNjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pxYRF_3i63hujsOpjw8X00-ri2AAUepn4tswEZNemO4)
![Screenshot 2023-11-14 at 8 39 02 PM](https://private-user-images.githubusercontent.com/13280642/282977970-4036153b-9ceb-42f8-b1d1-303456dab4b1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1MDcwMDIsIm5iZiI6MTcyMTUwNjcwMiwicGF0aCI6Ii8xMzI4MDY0Mi8yODI5Nzc5NzAtNDAzNjE1M2ItOWNlYi00MmY4LWIxZDEtMzAzNDU2ZGFiNGIxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIwVDIwMTgyMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ4ZGVhZGZmMWIwY2IyYTQ0MjkzNzI3MTY2Mjc1NTI1MjJlYjA0NWY5NDY5MzIxMDlmODFjNTI3Yjc4ZDQ0ODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.4Jf4o-slVWotpvdOTc8mzRYZmbTwSc00t73Wwqlp1Oc)