Fix DateRangePicker3 bug when initialMonth is equal to the maxDate's month #6548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
pushed a commit
that referenced
this pull request
Nov 15, 2023
Fix DateRangePicker3 bug when initialMonth is equal to the maxDate's month
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6546
The bug occurs when
initialMonthAndYearis equal to themaxDate's month and year resulting in a buggy selection state.We already handle this special case when using
props.initialMonthorvalue[0]as the initial month, this PR just expands the special case check to also include thetodayanddateBetweencases.Checklist
Changes proposed in this pull request:
Additionally checks that
todayordateBetween(if being used as initialMonth) is not the same month asmaxDates month and if it is use the previous monthReviewers should focus on:
Screenshot
Testing locally on the docs app setting the minDate as and
new Date(2023, 9, 23)and maxDate asnew Date(2023, 10, 15)before:
after:
