New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): popover target aria-expanded #6565

Merged

adidahiya merged 1 commit into palantir:develop from bvandercar-vt:bvandercar/popover-aria-expanded

Nov 27, 2023

Contributor

bvandercar-vt commented Nov 26, 2023

Add aria-expanded prop to popover target. Improve a11y.


          feat: popover aria-expanded

8d956bc

bvandercar-vt changed the title ~~feat: popover target aria-expanded~~ feat(a11y): popover target aria-expanded

adidahiya approved these changes

View reviewed changes

Contributor

adidahiya commented Nov 27, 2023

aria-expanded MDN docs for reference. It looks like this is compatible with "popup" elements and aria-haspopup 👍🏽

adidahiya merged commit 5c592b1 into palantir:develop

12 checks passed

adidahiya changed the title ~~feat(a11y): popover target aria-expanded~~ fix(a11y): popover target aria-expanded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment