fix(Popover): a11y aria props applied to child target, not wrapper #6604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adidahiya passing now |
adidahiya
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
there is some risk to this change as it touches a very fundamental component, but I think it's the right direction to move in. We had to make a similar attribute change in one of our apps due to a11y checks failing on the popover target element, so it would be great if Popover fixed this across the board for everyone by applying these aria- attributes on the correct DOM element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-expandedandaria-haspopovershould be applied to the interactive element, which is the passed child target, not the span wrapper. Compared to the span wrapper, the child element is the interactive element because A) it is likely to be an interactive element such as a<Button>and B) it's what gets thetabIndexprop.