Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-config] break: set 'react-hooks/exhaustive-deps' to error #6624

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

adidahiya
Copy link
Contributor

Changes proposed in this pull request:

  • [eslint-config] break: set react-hooks/exhaustive-deps rule to "error" instead of "warn"
  • chore: fix exhaustive-deps lint errors across monorepo

Reviewers should focus on:

No behavior regressions

@adidahiya
Copy link
Contributor Author

[eslint-config] break: set 'react-hooks/exhaustive-deps' to error

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

adjust PanelView2 onClose memoization

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit a90c947 into develop Jan 4, 2024
12 checks passed
@adidahiya adidahiya deleted the ad/react-exhaustive-deps branch January 4, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant