Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(Popover): resolve React warning by persisting synthetic event #6651

Merged
merged 3 commits into from
Jan 12, 2024
Merged

[core] fix(Popover): resolve React warning by persisting synthetic event #6651

merged 3 commits into from
Jan 12, 2024

Conversation

braeden
Copy link
Contributor

@braeden braeden commented Jan 11, 2024 •
edited

Fixes #0000

Warning: This synthetic event is reused for performance reasons. If you're seeing this, you're accessing the property `nativeEvent` on a released/nullified synthetic event. This is set to null. If you must keep the original synthetic event around, use event.persist(). See https://fb.me/react-event-pooling for more information.

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

@braeden braeden changed the title Persist the React SyntheticEvent when lifetime extends beyond current event loop cycle Persist the React SyntheticEvent when lifetime extends beyond current event loop cycle Jan 11, 2024
@adidahiya
Copy link
Contributor

Prettier maybe

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya changed the title Persist the React SyntheticEvent when lifetime extends beyond current event loop cycle [core] fix(Popover): resolve React warning by persisting synthetic event Jan 12, 2024
@adidahiya adidahiya enabled auto-merge (squash) January 12, 2024 14:17
@adidahiya
Copy link
Contributor

fix formatting

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 0fd5635 into develop Jan 12, 2024
12 checks passed
@adidahiya adidahiya deleted the braedens/fix-event-persistance branch January 12, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@braeden @adidahiya