Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(HotkeysProvider): memoize context value #6652

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

braeden
Copy link
Contributor

@braeden braeden commented Jan 11, 2024

Related to #5178

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Split out the memoization work from #6643 since it should be very-safe to land.

  • Prevent unnecessary renders when the state doesn't change
  • The useReducer/useState array isn't stable between renders, otherwise we could just use that directly.

Reviewers should focus on:

Screenshot

@adidahiya
Copy link
Contributor

Memoize hotkeysProvider value

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks @braeden!

@adidahiya adidahiya changed the title Memoize HotkeysProvider context value [core] fix(HotkeysProvider): memoize context value Jan 12, 2024
@adidahiya adidahiya merged commit c47f02e into develop Jan 12, 2024
12 checks passed
@adidahiya adidahiya deleted the braedens/memo-hotkey-value branch January 12, 2024 14:11
@braeden braeden mentioned this pull request Jan 31, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants