[core] break(Portal): stop using legacy context in React 18 #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] break(Portal): stop using legacy context in React 18Build artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6572
Checklist
Changes proposed in this pull request:
Portal): stop using legacy context API in React 18Reviewers should focus on:
We assume that React 18 users of Blueprint are not using legacy APIs. The
<Portal>component currently has support for both the new context API and the legacy one. The backwards-compatible implementation (initialized viaPortal.contextTypes = ...) triggers a warning in React 18 strict mode which we would like to avoid (see #6572).This is a breaking change but likely a welcome one for React 18 users. Open to feedback; leave a comment below.
Screenshot