Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat: CompoundTag #6686

Merged
merged 10 commits into from
Jan 31, 2024
Merged

[core] feat: CompoundTag #6686

merged 10 commits into from
Jan 31, 2024

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Jan 30, 2024

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

New CompoundTag component

Reviewers should focus on:

Implementation matches Figma designs

Screenshot

Variant Light theme Dark theme
Default image image
Intent image image
Minimal image image
Minimal intent image image
Round Large Large + Fill + Icons
image image image

Interactive demo

Screen Recording 2024-01-30 at 12 14 08 PM

@adidahiya
Copy link
Contributor Author

Add unit tests

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@jessperrin
Copy link
Contributor

These are the values for the minimal tag secondary background:
image

And the values for default tag secondary background:
image

@jessperrin
Copy link
Contributor

One more update: Per the darkmode updates, darkmode default tag colors should be the same as lightmode default tag, both backgrounds + text

@adidahiya
Copy link
Contributor Author

fix tag tests

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

@jessperrin thanks for the color table, I will fix those.

The hover and active colors are under-specified right now -- I am using the darker values (referenced in my PR comment above) for active states like this:

image

@adidahiya
Copy link
Contributor Author

fix colors

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@jessperrin
Copy link
Contributor

Played around with the docs, a couple notes:
-The non-rounded compound tag should still have the same outside corner radius as the normal tag (2px?), instead of the square corners
-Adding the left icon but not the right increases the left tag height to be mismatched with the right:
image

@adidahiya
Copy link
Contributor Author

remove multiline prop from CompoundTag

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor Author

fix tests, make leftContent and children required

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya adidahiya merged commit 13866c7 into develop Jan 31, 2024
11 of 12 checks passed
@adidahiya adidahiya deleted the ad/compound-tag branch January 31, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants