[core] feat: more dark theme color aliases #6724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
[core] feat: more dark theme color aliasesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
Add generated changelog entriesBuild artifact links for this commit: documentation | landing | table | demoThis is an automated comment from the deploy-preview CircleCI job. |
adidahiya
commented
Feb 23, 2024
adidahiya
commented
Feb 23, 2024
|
|
||
| &.#{$ns}-dark { | ||
| background-color: $dark-content-background-color; | ||
| background-color: $pt-dark-app-background-color; |
There was a problem hiding this comment.
actually, strike that last comment -- the change to docs-theme is fine. the color aliases being used were inconsistent before; we were using "app background color" for light theme but something else for dark theme, and this change unifies them to be symmetrical. so it's a welcome fix for the docs-theme package and it doesn't darken things so much that we need all the adjustments from #6711
adidahiya
added a commit
that referenced
this pull request
Feb 26, 2024
Co-authored-by: svc-changelog <svc-changelog@palantir.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported relevant preflight changes from #6711 to help with a smoother migration to the newer dark theme colors
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
No regressions / visual changes in docs styling
Screenshot