Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DateTime2): export TimePicker #6868

Conversation

bvandercar-vt
Copy link
Contributor

Fixes #6739

Checklist

  • [N/A] Includes tests
  • [N/A] Update documentation

Changes proposed in this pull request:

Export TimePicker from datetime2 package, from the original datetime package, like is already being done for TimezoneSelect as well as other componentes/ types.

Reviewers should focus on:

Other components/types are exported this way in the same file

@changelog-app
Copy link

changelog-app bot commented Jun 25, 2024

Generate changelog in packages/datetime2/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

feat(DateTime2): export TimePicker

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@evansjohnson evansjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this! I've found the lack of consistency here confusing in the past as well.

I imagine the original intent was to push users to import from datetime, as that is ultimately the package users will import all of these from, but I think the partial re-export state is more confusing than is worth it to push users to datetime imports early.

packages/datetime2/src/index.ts Show resolved Hide resolved
packages/datetime2/src/index.ts Show resolved Hide resolved
Copy link
Contributor

@evansjohnson evansjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for taking another pass! happy to approve if we add deprecation messages back

with that I'm leaning towards respecting existing behavior more so than actually thinking they're helpful, but I do see some argument for them which I left in the comment

packages/datetime2/src/index.ts Show resolved Hide resolved
DateInput as DateInput2,
/** @deprecated import from `@blueprintjs/datetime` instead */
/** @deprecated use `DateInput3Props` instead */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be in support of improving this deprecation message with an "or preferably use ___3"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just changed it back to the old one

@evansjohnson evansjohnson self-assigned this Jun 26, 2024
"DateInput2",
"DateInput2MigrationUtils",
"DateRangeInput2",
"MonthAndYear",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, do you know what this was needed for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test was failing and MonthAndYear is also excluded in the same place in /datetime/test/isotest.mjs

@evansjohnson evansjohnson merged commit fa69aca into palantir:develop Jun 28, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include TimePicker in Datetime2 package?
2 participants