Fix input group action static color #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
reviewed
Feb 20, 2017
| color: $pt-text-color-muted; | ||
|
|
||
| // same goes for dark | ||
| // stylelint-disable selector-max-compound-selectors |
There was a problem hiding this comment.
stylelint-disable-next-line automatically re-enables
cmslewis
reviewed
Feb 20, 2017
|
|
||
| // same goes for dark | ||
| // stylelint-disable selector-max-compound-selectors | ||
| .pt-dark & { color: $pt-dark-text-color-muted; } |
There was a problem hiding this comment.
nit: I prefer to format even single-rule blocks the normal way:
.pt-dark & {
color: $pt-dark-text-color-muted;
}
There was a problem hiding this comment.
i personally love a good one-liner, but the multiline syntax is definitely preferred in this codebase.
cmslewis
approved these changes
Feb 20, 2017
giladgray
approved these changes
Feb 20, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (lighter than placeholder, bad):
After:
