[DateRangeInput] Show formatted min/max dates on focus when inputs empty #874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #805
Checklist
Changes proposed in this pull request:
Reviewers should focus on:
min/max === null
, but that's already not really a supported case. Can address that more generally in a future PR if we want.this.state
, then we'll have to cast those vanilla JS dates tomoment
s on every render just to achieve properly formatted placeholder dates, which is exceedingly wasteful.Screenshot