Do not use pull request body as message if delimiters are not present #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluekeyes
approved these changes
Jun 27, 2019
|
@bluekeyes can we cut a release with this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#72 merged quite a while ago but nearly all excavator PR still do not use the delimiters. Thus all excavator PRs have very long commit messages that make it cumbersome to view the commit history.
This PR changes the behavior to explicitly exclude the pull request body if the PR does not include the specified delimiter. Now, by default excavator PRs will not have their body included in the commit message unless the explicitly opt-in and include the delimiters.