-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Error Code: CONFLICT(409) #43
Comments
Is failed precondition not good enough for this?
Sent from Email+ secured by MobileIron
…-------- Original Message --------
From: Beck Chen <notifications@github.com<mailto:notifications@github.com>>
Date: Fri, Sep 1, 2017, 11:47 PM
To: palantir/http-remoting-api <http-remoting-api@noreply.github.com<mailto:http-remoting-api@noreply.github.com>>
CC: Subscribed <subscribed@noreply.github.com<mailto:subscribed@noreply.github.com>>
Subject: [palantir/http-remoting-api] New Error Code: CONFLICT(409) (#43)
Wanted to add a new error code into the list available in ErrorType: Conflict (409)[w3.org]<https://urldefense.proofpoint.com/v2/url?u=https-3A__www.w3.org_Protocols_rfc2616_rfc2616-2Dsec10.html-23sec10.4.10&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=UfcWCaR4ui50AFap-gezrx5XYtPtH-9JpazU7tbRW-4&m=rqN-aEuRiO7Ygxko0UCfrIQ6Wy5uVo3U-y0glp-HTXQ&s=ObRDtv8i7UoRkOLK94WKU357bHumdsC-eDihd-46jJk&e=>
Use case is for reporting error when a request wants to open a new transaction when one already exists, as our service does not currently support simultaneous open transactions. I think 409 is the HTTP code that most accurately describes this error.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub[github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_http-2Dremoting-2Dapi_issues_43&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=UfcWCaR4ui50AFap-gezrx5XYtPtH-9JpazU7tbRW-4&m=rqN-aEuRiO7Ygxko0UCfrIQ6Wy5uVo3U-y0glp-HTXQ&s=109mipz7sV1TYtpHLdEvUiB5qEFBsftfzsCW1IY8I3U&e=>, or mute the thread[github.com]<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AGOdwaPq0nBcMSyJ6fXQQi7153FuWALIks5seHtsgaJpZM4PKqfH&d=DwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=UfcWCaR4ui50AFap-gezrx5XYtPtH-9JpazU7tbRW-4&m=rqN-aEuRiO7Ygxko0UCfrIQ6Wy5uVo3U-y0glp-HTXQ&s=MMaFKHjzFhFBA6Tb-Kntli368fPnLE9w1DWAKskBwWs&e=>.
|
Failed precondition sounds close, but it's a 500, and I think in my case a client error is more appropriate since nothing actually goes wrong on the server side. |
OK, that's fair. I think we can add CONFLICT (409). |
Merged
uschi2000
pushed a commit
that referenced
this issue
Sep 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wanted to add a new error code into the list available in
ErrorType
: Conflict (409)Use case is for reporting error when a request wants to open a new transaction when one already exists, as our service does not currently support simultaneous open transactions. I think 409 is the HTTP code that most accurately describes this error.
The text was updated successfully, but these errors were encountered: