Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Error Code: CONFLICT(409) #43

Closed
meditativeape opened this issue Sep 1, 2017 · 3 comments · Fixed by #44
Closed

New Error Code: CONFLICT(409) #43

meditativeape opened this issue Sep 1, 2017 · 3 comments · Fixed by #44

Comments

@meditativeape
Copy link
Contributor

Wanted to add a new error code into the list available in ErrorType: Conflict (409)

Use case is for reporting error when a request wants to open a new transaction when one already exists, as our service does not currently support simultaneous open transactions. I think 409 is the HTTP code that most accurately describes this error.

@uschi2000
Copy link
Contributor

uschi2000 commented Sep 1, 2017 via email

@meditativeape
Copy link
Contributor Author

Failed precondition sounds close, but it's a 500, and I think in my case a client error is more appropriate since nothing actually goes wrong on the server side.

@uschi2000
Copy link
Contributor

OK, that's fair. I think we can add CONFLICT (409).

uschi2000 pushed a commit that referenced this issue Sep 3, 2017
uschi2000 pushed a commit that referenced this issue Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants