Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoteException.getMessage includes SerializableError parameters #633

Merged
merged 2 commits into from
Apr 21, 2022
Merged

RemoteException.getMessage includes SerializableError parameters #633

merged 2 commits into from
Apr 21, 2022

Commits on Feb 23, 2021

  1. RemoteException.getMessage includes SerializableError parameters 

    In connected environments this makes no difference because
RemoteException.getMessage is never called, only getLogMessage.
In such cases the error instance identifier is sufficient to
search for the original failure information, however service
authors without safe-logging infrastructure are unlikely to have
access to remote instance logging and should be presented with
the failure parameters in local logging.

The message is computed lazily, very slightly reducing overhead
in environments that don't use the unsafe message, while providing
additional actionable signal to others.
    @carterkozak
    carterkozak committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    baba52a View commit details
    Browse the repository at this point in the history

  2. Add generated changelog entries

    @carterkozak
    carterkozak committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    0bf9c2e View commit details
    Browse the repository at this point in the history