Add a reason field to QosException #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Dec 12, 2022
errors/src/main/java/com/palantir/conjure/java/api/errors/QosException.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Carter Kozak <ckozak@palantir.com>
|
Good work, I'm happy with this. I'll plan to merge end of day unless other folks have concerns. |
|
Released 2.31.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Services throw
QosExceptions to protect themselves from becoming overloaded. It's useful to know why a service responded with aQosExceptionfor better observability. However, the exceptions are currently logged at thedebuglevel, which is disabled by default. It would be costly to log the exceptions at aninfo(or higher) level.This PR introduces new
QosExceptionfactory methods which allow users to store a reason (an object of newly defined typeQosReason) for throwing an exception.After this PR
==COMMIT_MSG==
Add a reason field to QosException
==COMMIT_MSG==
Note: This change has been reviewed in #925. This PR was created from a branch on the repository, instead of a fork, to enable the changelog bot.