Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QosException reasons are included in SafeLoggable args #930

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

carterkozak
Copy link
Contributor

Before this PR

No insight into the qos reason unless the qos-exception was handled explicitly

After this PR

==COMMIT_MSG==
QosException reasons are included in SafeLoggable args for better observability when exceptions are wrapped and logged.
==COMMIT_MSG==

@changelog-app
Copy link

changelog-app bot commented Dec 14, 2022

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

QosException reasons are included in SafeLoggable args for better observability when exceptions are wrapped and logged.

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@mpritham mpritham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you

@bulldozer-bot bulldozer-bot bot merged commit cb06ccc into develop Dec 14, 2022
@bulldozer-bot bulldozer-bot bot deleted the ckozak/qosreason_arg branch December 14, 2022 22:05
@svc-autorelease
Copy link
Collaborator

Released 2.32.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants