Feature/release prep #1
Conversation
…seline expectations - Some modifications to Gradle plugin configuration in sub projects - No code changes other than updating of copyright headers
| @@ -1 +0,0 @@ | |||
| org.eclipse.jdt.apt.genSrcDir=.generated | |||
There was a problem hiding this comment.
This made the generated source go to .generated instead of generated_src, which I understood to be consistent with IntelliJ.
There was a problem hiding this comment.
I'd just leave it to the processors plugin to decide where generated sources should go -- it defaults to generated_src. Since version 0.2.2, baseline has better out-of-the-box compatibility with the processors plugin, so this file is no longer needed.
There was a problem hiding this comment.
This is an eclipse default, not a processors plugin default.
Sent from my iPhone
On Nov 29, 2015, at 2:39 PM, Robert Fink <notifications@github.commailto:notifications@github.com> wrote:
In .baseline/eclipse/static/dotfile.settings/org.eclipse.jdt.apt.core.prefshttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_http-2Dremoting_pull_1-23discussion-5Fr46096843&d=CwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=bBjvBb2zbbksX47nVTf3lWuPPBc4luW3AU5KoQhCOlw&s=sWXOBfz8fu773bNlHzEM4Mu2g5WP1wjfC-cXoqejCio&e=:
@@ -1 +0,0 @@
-org.eclipse.jdt.apt.genSrcDir=.generated
I'd just leave it to the processors plugin to decide where generated sources should go -- it defaults to generated_src. Since version 0.2.2, baseline has better out-of-the-box compatibility with the processors plugin, so this file is no longer needed.
—
Reply to this email directly or view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_palantir_http-2Dremoting_pull_1_files-23r46096843&d=CwMCaQ&c=izlc9mHr637UR4lpLEZLFFS3Vn2UXBrZ4tFb6oOnmz8&r=Vp81aOxWZvuVgVK_wp-VF3pIYG92B19LcCw6XKeYC0U&m=bBjvBb2zbbksX47nVTf3lWuPPBc4luW3AU5KoQhCOlw&s=a2TXJB21FFFXG7wo5nxMA0ienIdZaYIMWSHy-TSS0og&e=.
There was a problem hiding this comment.
Well, even better then?
There was a problem hiding this comment.
The point was to make the intellij and eclipse setups closer.
There was a problem hiding this comment.
Yep, the processors plugin takes care of this: https://github.com/palantir/gradle-processors/blob/master/src/main/groovy/org/inferred/gradle/ProcessorsPlugin.groovy
project.processors {
// Used by Eclipse and IDEA
sourceOutputDir = 'generated_src'
// Used by IDEA (Eclipse does not compile test sources separately)
testSourceOutputDir = 'generated_testSrc'
}
There was a problem hiding this comment.
Happy to override to 'generated' if you prefer?
|
ok, good with this too. |
@markelliot