[fix] Add back acquire limiter span #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
changed the title
|
Looks great 👍 |
iamdanfox
reviewed
Apr 1, 2019
| com.squareup.okhttp3:logging-interceptor:3.13.1 (1 constraints: d608d786) | ||
| com.squareup.okhttp3:okhttp:3.13.1 (5 constraints: 8745dcdf) | ||
| com.squareup.okhttp3:logging-interceptor:3.14.0 (1 constraints: d608d786) | ||
| com.squareup.okhttp3:okhttp:3.14.0 (5 constraints: b3456615) |
There was a problem hiding this comment.
Decent number of changes went into https://github.com/square/okhttp/blob/master/CHANGELOG.md#version-3140. Seems like they're getting further and further away from a version of conscrypt that still works on Centos6 :/
bulldozer-bot bot
pushed a commit
that referenced
this pull request
Apr 3, 2019
…ody NoSuchMethodErrors (#1039) ## Before this PR #1026 (which went into 4.20.1) inadvertently brought in a bump in okhttp to 3.14.0. One of our internal libraries relied on `UnrepeatableRequestBody` which got removed in github.com/square/okhttp/pull/4676, and a solution using `RequestBody#isOneShot` couldn't be made that exhibits the previous behaviour. ## After this PR Downgrading okhttp to 3.13.1, and adding a constraint to prevent accidental upgrades to 3.14.0 for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
There was no way to measure time spent in acquire limiter
After this PR
==COMMIT_MSG==
OkHttp: enqueue span is renamed to OkHttp: execute and gets OkHttp: execute-enqueue for time spent acquiring limiter and OkHttp: execute-run for execution of the call
==COMMIT_MSG==
Possible downsides?