Upgrade Undertow to 2.2.24.Final #2580
Conversation
| # updated to jakarta only. This should NEVER be done in production code, it is only used | ||
| # here to enable existing test coverage. | ||
| io.undertow:undertow-servlet-jakarta = 2.2.20.Final | ||
| # dependency-upgrader:ON |
There was a problem hiding this comment.
@carterkozak should we also bump com.palantir.conjure.java to 7.5.0 in this release? I'm also not sure why we have separate pin for com.palantir.conjure.java:conjure-lib = 7.4.0
com.palantir.conjure.java:* = 7.5.0
There was a problem hiding this comment.
Good call on the unnecessary conjure-lib, I'm not sure where that came from. I don't think conjure-java 7.5.0 is published yet
There was a problem hiding this comment.
yeah, I got 404s locally for com.palantir.conjure.java:conjure-lib:7.5.0 just a second ago. Will +1 and defer to you if you want to wait for the publish to complete before merging this & cutting CJR release as well
There was a problem hiding this comment.
Removing the duplication causes consistent CI failures. I'm going to undo that piece and investigate later on.
| # updated to jakarta only. This should NEVER be done in production code, it is only used | ||
| # here to enable existing test coverage. | ||
| io.undertow:undertow-servlet-jakarta = 2.2.20.Final | ||
| # dependency-upgrader:ON |
There was a problem hiding this comment.
yeah, I got 404s locally for com.palantir.conjure.java:conjure-lib:7.5.0 just a second ago. Will +1 and defer to you if you want to wait for the publish to complete before merging this & cutting CJR release as well
carterkozak
force-pushed
the
ckozak/latest-undertow
branch
from
914c564
to
69aa8d9
Compare
versions.props
Outdated
| com.palantir.conjure.java:* = 7.4.0 | ||
| com.palantir.conjure.java:conjure-lib = 7.4.0 | ||
| com.palantir.conjure.java:* = 7.5.0 | ||
| om.palantir.conjure.java:conjure-lib = 7.5.0 |
There was a problem hiding this comment.
sorry about the wild goose chase on this, something seems odd with :conjure-java-client-verifier requiring this pin, but fine leaving this extra pin here
| om.palantir.conjure.java:conjure-lib = 7.5.0 | |
| com.palantir.conjure.java:conjure-lib = 7.5.0 |
There was a problem hiding this comment.
👍 I'll follow up on this one separately
There was a problem hiding this comment.
yeah, not urgent, just seemed odd when looking through pins, but here be 🐉
|
Released 7.45.0 |
==COMMIT_MSG==
Upgrade Undertow to 2.2.24.Final
==COMMIT_MSG==
Possible downsides?
Oddness due to interactions between the undertow javax/jakarta migration scheme and the way gradle-consistent-versions works. We test with an older undertow-servlet release, which is dangerous, but a reasonable risk in test-only code. Previously we sat on an old release.