Add TypeFactory cache instrumentation #2588
Conversation
Generate changelog in
|
| type: histogram | ||
| tags: | ||
| - format | ||
| docs: Histogram describing the length of strings parsed from input. |
There was a problem hiding this comment.
This was a rename to jackson-metrics since -registry didn't make a lot of sense in the filename.
| long hits = hit.getCount() - hitBefore; | ||
| long misses = miss.getCount() - missBefore; | ||
|
|
||
| assertThat(hits).isGreaterThan(0); |
There was a problem hiding this comment.
should this be 0 hits?
| assertThat(hits).isGreaterThan(0); | |
| assertThat(hits).isZero(); |
There was a problem hiding this comment.
Internally this ends up around 3 due to various components mapping the same type. It's probably best not to make any asserts at all at this point, then assert the value has increased in the second round
There was a problem hiding this comment.
I'll update the test to operate directly on the TypeFactory since the ObjectMapper complicates things
| missBefore = miss.getCount(); | ||
| mapper.writeValue(ByteStreams.nullOutputStream(), new SimpleSerializable()); | ||
| misses = miss.getCount() - missBefore; | ||
| assertThat(misses).isZero(); |
There was a problem hiding this comment.
should we check that hits > 0 here?
| assertThat(misses).isZero(); | |
| assertThat(hit.getCount() - hits).isGreaterThan(0); |
|
Released 7.49.0 |
==COMMIT_MSG==
Add TypeFactory cache instrumentation
==COMMIT_MSG==