Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dependency on Jackson Afterburner #2879

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Conversation

carterkozak
Copy link
Contributor

Afterburner is not used on supported JDKs, there's no reason to include the dependency.

==COMMIT_MSG==
Remove Dependency on Jackson Afterburner
==COMMIT_MSG==

Possible downsides?

Slight possibility that code running on jdk-11 may observe a very slight performance regression. In practice we haven't seen much difference between registering afterburner and not.

@changelog-app
Copy link

changelog-app bot commented Apr 10, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Remove Dependency on Jackson Afterburner

Check the box to generate changelog(s)

  • Generate changelog entry

pkoenig10
pkoenig10 previously approved these changes Apr 10, 2024
@policy-bot policy-bot bot dismissed pkoenig10’s stale review April 10, 2024 19:09

Invalidated by push of 11674c8

@carterkozak
Copy link
Contributor Author

woops, mind giving this another +1?

carterkozak and others added 3 commits April 10, 2024 16:21
Afterburner is not used on supported JDKs, there's no reason to
include the dependency.
@tpetracca
Copy link
Contributor

👍🏻

@bulldozer-bot bulldozer-bot bot merged commit 8380306 into develop Apr 10, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/no_afterburner branch April 10, 2024 20:26
@svc-autorelease
Copy link
Collaborator

Released 8.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants