use our own boxing and unboxing logic instead of poet's #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsingh123
commented
Feb 16, 2023
|
|
||
| public static TypeName unbox(TypeName type) { | ||
| List<AnnotationSpec> annotations = type.annotations; | ||
| return type.withoutAnnotations().unbox().annotated(annotations); |
There was a problem hiding this comment.
this is fine because poet checks equality by object for boxed primitives but by reference for primitives
carterkozak
approved these changes
Feb 16, 2023
|
Released 6.71.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poet's boxing logic is incompatible with annotated primitives, resulting in breaks like this one, which is repro'd in the first commit on this branch. use our own boxing logic to avoid this error