Missing credentials result in 401 UNAUTHORIZED responses from conjure-undertow #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
.../src/main/java/com/palantir/conjure/java/undertow/runtime/ConjureAuthorizationExtractor.java
Outdated
Show resolved
Hide resolved
...java-undertow-runtime/src/test/java/com/palantir/conjure/java/undertow/runtime/AuthTest.java
Outdated
Show resolved
Hide resolved
...java-undertow-runtime/src/test/java/com/palantir/conjure/java/undertow/runtime/AuthTest.java
Outdated
Show resolved
Hide resolved
…e-undertow Previously we responded with a 400 bad request status, which isn't as accurate as we would like. Added cusom `Conjure` namespaced ErrorTypes for better observability, updated existing FrameworkExceptions to do the same.
carterkozak
force-pushed
the
ckozak/unauthorized
branch
from
beadfe3
to
b71ba24
Compare
| return new FrameworkException(message, StatusCodes.UNPROCESSABLE_ENTITY, cause, args); | ||
| static FrameworkException unprocessableEntity( | ||
| @CompileTimeConstant String message, Throwable cause, Arg<?>... args) { | ||
| return new FrameworkException(message, UNPROCESSABLE_ENTITY, StatusCodes.UNPROCESSABLE_ENTITY, cause, args); |
There was a problem hiding this comment.
we should get the status code out of the ErrorType.Code directly rather than potentially creating a mismatch
There was a problem hiding this comment.
FrameworkException is an internal detail of conjure-undertow to support failures which do not have a status code in ErrorType.Code.
There was a problem hiding this comment.
Never mind, I guess you can't really do that since that enum doesn't define a code for 412 nor 415 🙄
uschi2000
reviewed
Nov 26, 2019
...tow-runtime/src/main/java/com/palantir/conjure/java/undertow/runtime/FrameworkException.java
Show resolved
Hide resolved
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we responded with a 400 bad request status, which isn't quite accurate.
Added custom
Conjurenamespaced ErrorTypes for better observability,updated existing FrameworkExceptions to do the same.
After this PR
==COMMIT_MSG==
Missing credentials result in 401 UNAUTHORIZED responses from conjure-undertow
Previously we responded with a 400 bad request status, which isn't as accurate as we would like.
==COMMIT_MSG==