[improvement] Optional arguments in method definitions default to None #14
Conversation
| docs: | | ||
| List of strings to filter on. | ||
| type: optional<list<integer>> | ||
| param-type: query |
There was a problem hiding this comment.
can we make one of these path parameters?
There was a problem hiding this comment.
Are path parameters allowed to be optional? I get java.lang.IllegalStateException: Path parameters must be primitives or aliases when I try.
There was a problem hiding this comment.
right, ya path params can't be optional. I meant to say headers, oops
| @@ -366,7 +366,7 @@ def _fields(cls): | |||
| _map = None # type: Dict[str, str] | |||
| _alias = None # type: StringAliasExample | |||
|
|
|||
| def __init__(self, string, integer, double_value, optional_item, items, set, map, alias): | |||
| def __init__(self, string, integer, double_value, optional_item=None, items, set, map, alias): | |||
There was a problem hiding this comment.
This is illegal, @ferozco are we allowed to sort optional parameters to the end of the list?
SyntaxError: non-default argument follows default argument
There was a problem hiding this comment.
ya of course! we can group by optionality then lex sort them
|
+add a slightly more descriptive PR name and/or changelog entry, please. |
ahggns
changed the title
|
Lets follow up on conjure-verification with additional test cases for optional query parameters, then pick them up here before merging this in |
|
@ferozco this is ready for another look |
| @@ -155,4 +166,18 @@ static Builder builder() { | |||
|
|
|||
| } | |||
|
|
|||
|
|
|||
| class PythonFieldComparator implements Comparator<PythonField> { | |||
There was a problem hiding this comment.
There were a couple bad options:
(1) Try to merge PythonField and PythonEndpointParam, I didn't like this because they have some slightly different behavior, though maybe they shouldn't.
(2) Build an interface PythonNamedMaybeOptionalEntity, doesn't have to be that silly but seemed overly specific to the workflow.
(3) Do nothing.
I chose (3), maybe one of those other options is less bad or there's a fourth superior thing.
| @@ -488,7 +488,7 @@ def _fields(cls): | |||
| _bearertoken = None # type: Optional[str] | |||
| _uuid = None # type: Optional[str] | |||
|
|
|||
| def __init__(self, num, bool, integer, safelong, rid, bearertoken, uuid): | |||
| def __init__(self, bearertoken=None, bool=None, integer=None, num=None, rid=None, safelong=None, uuid=None): | |||
| def run_test_with_argument(index, is_blacklisted, service, method_name, value): | ||
| target_method = getattr(service, method_name) | ||
| target_argspec = inspect.getargspec(target_method) | ||
| target_param = [e |
No description provided.