Excavator: Format Java files #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svc-excavator-bot
force-pushed
the
roomba/format
branch
6 times, most recently
from
9403e43
to
49c35ef
Compare
svc-excavator-bot
force-pushed
the
roomba/format
branch
2 times, most recently
from
de6573e
to
e9ab158
Compare
CRogers
reviewed
Feb 10, 2020
| endpointName, | ||
| ImmutableMap.of( | ||
| "http", | ||
| "GET /" + endpointName + "/{index}", |
There was a problem hiding this comment.
This looks like a regression @dansanduleac
There was a problem hiding this comment.
I think this might be hitting some obscure edge case that tries to assert that N/2+1 rows have the same "kind" of tree in the AST.
The values here seem to be
- Kind.PLUS (BinaryTree of
+operations) - Kind.VARIABLE
- Kind.METHOD_INVOCATION
I honestly don't see much reason for this kind of heuristic, so it might make sense to remove it.
svc-excavator-bot
force-pushed
the
roomba/format
branch
from
e9ab158
to
3a555b8
Compare
|
Putting do not merge until we address the issues with the map arguments being split |
svc-excavator-bot
force-pushed
the
roomba/format
branch
from
3a555b8
to
9b92256
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
excavator is a bot for automating changes across repositories.
Changes produced by the roomba/format check.
To enable or disable this check, please contact the maintainers of Excavator.