Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing map key validation #1448

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Fixing map key validation #1448

merged 4 commits into from
Jan 8, 2024

Conversation

jj-marinho
Copy link
Contributor

@jj-marinho jj-marinho commented Sep 10, 2023

Before this PR

One of the examples of: #1447

Map key validation didn't recursively look inside map value types correctly.

After this PR

Now it does check inside the map value.

==COMMIT_MSG==
Fixing map key validation
==COMMIT_MSG==

Possible downsides?

@jj-marinho jj-marinho linked an issue Sep 10, 2023 that may be closed by this pull request
@changelog-app
Copy link

changelog-app bot commented Sep 10, 2023

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Fixing map key validation

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@carterkozak carterkozak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bulldozer-bot bulldozer-bot bot merged commit dc42a32 into master Jan 8, 2024
5 checks passed
@bulldozer-bot bulldozer-bot bot deleted the map-key-validation branch January 8, 2024 19:33
@svc-autorelease
Copy link
Collaborator

Released 4.39.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator failing to validate nested type definitions
4 participants