-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JDK version to user agent #1797
Conversation
Generate changelog in
|
@@ -60,7 +61,7 @@ public ListenableFuture<Response> execute(Request request) { | |||
} | |||
|
|||
private static UserAgent augmentUserAgent(UserAgent baseAgent, Endpoint endpoint) { | |||
return tryAddEndpointAgent(baseAgent, endpoint).addAgent(DIALOGUE_AGENT); | |||
return tryAddEndpointAgent(baseAgent, endpoint).addAgent(DIALOGUE_AGENT).addAgent(JDK_AGENT); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm considering exposing something like UserAgent addAgents(Iterable<Agent>)
to conjure-java-runtime-api
to avoid multiple immutable copies, but that can be a follow on PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing in favor of #1802 |
Before this PR
Diagnosing the JDK version a specific Dialogue client is using to make requests is difficult.
After this PR
==COMMIT_MSG==
Adds JDK version to the dialogue user agent string, e.g. jdk/17.0.4.1
==COMMIT_MSG==
Possible downsides?