Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogue fails fast when existing channels are revoked from DNS #2263

Merged
merged 4 commits into from
May 1, 2024

Conversation

carterkozak
Copy link
Contributor

We don't want to spend ages retrying requests to dead nodes, where we expect every attempt to result in a connect timeout. It's much better to fail quickly rather than retry+backoff for minutes.

==COMMIT_MSG==
Dialogue fails fast when existing channels are revoked from DNS
==COMMIT_MSG==

Possible downsides?

if dns entries disappear and reappear, we may have failed requests for nothing. It's possible dns entires may be revoked while requests are still routable, but I don't think we should prioritize this case as it's generally not something we expect to support.

We don't want to spend ages retrying requests to dead nodes, where
we expect every attempt to result in a connect timeout. It's much
better to fail quickly rather than retry+backoff for minutes.
@changelog-app
Copy link

changelog-app bot commented May 1, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Dialogue fails fast when existing channels are revoked from DNS

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@bjlaub bjlaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bulldozer-bot bulldozer-bot bot merged commit fb4a00f into develop May 1, 2024
6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the ckozak/fail_fast branch May 1, 2024 20:49
@svc-autorelease
Copy link
Collaborator

Released 3.128.0

carterkozak added a commit that referenced this pull request May 3, 2024
carterkozak added a commit that referenced this pull request May 3, 2024
…NS" (#2268)

* Revert "Dialogue fails fast when existing channels are revoked from DNS (#2263)"

This reverts commit fb4a00f.

* Add generated changelog entries

---------

Co-authored-by: svc-changelog <svc-changelog@palantir.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants