client tolerates unexpected body #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Feb 20, 2020
| } catch (IOException e) { | ||
| throw new SafeRuntimeException("Failed to read from response body", e); | ||
| } | ||
| input.close(); |
There was a problem hiding this comment.
Let's leave a comment describing that void->type is allowed. Is there a quick test we can add?
There was a problem hiding this comment.
👍 I'll add a comment, I already added tests :)
added 2 commits
February 20, 2020 10:32
iamdanfox
approved these changes
Feb 20, 2020
|
Released 0.9.1 |
uschi2000
reviewed
Feb 21, 2020
| @@ -141,6 +141,18 @@ public void testBlocking_stringToString_throwsWhenResponseBodyIsEmpty() { | |||
| .hasMessageContaining("Failed to deserialize response stream. Syntax error?"); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testBlocking_voidToVoid_doesNotThrowsWhenResponseBodyIsNonEmpty() { | |||
uschi2000
reviewed
Feb 21, 2020
| } catch (IOException e) { | ||
| throw new SafeRuntimeException("Failed to read from response body", e); | ||
| } | ||
| // We should not fail if a server that previously return nothing starts returning a response |
There was a problem hiding this comment.
nit: grammar is a little funky here
There was a problem hiding this comment.
was there a bug here previously w.r.t. the missing input.close()? if so, can you add a test?
There was a problem hiding this comment.
No there was not a bug, it was previously closed by the try-with-resource. It was simply more concise to call close directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
If a client received a response but was not expecting one it would throw
After this PR
==COMMIT_MSG==
Clients are tolerant of unexpected response body
==COMMIT_MSG==
Possible downsides?
N/A