instrument retrying channels scheduled executor service #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
carterkozak
reviewed
Mar 4, 2020
| @@ -80,6 +83,7 @@ | |||
| ClientConfiguration.RetryOnTimeout retryOnTimeout) { | |||
| this( | |||
| delegate, | |||
| new DefaultTaggedMetricRegistry(), | |||
There was a problem hiding this comment.
I think we need to add this to the constructor and pass the registry from our ClientConfiguration
There was a problem hiding this comment.
Yes we do do that, this constructor is only visible for testing. Let me make that more clear
There was a problem hiding this comment.
oh doh, I misread, sorry!
carterkozak
reviewed
Mar 4, 2020
| private static ListeningScheduledExecutorService instrument( | ||
| ScheduledExecutorService delegate, TaggedMetricRegistry metrics) { | ||
| return MoreExecutors.listeningDecorator( | ||
| Tracers.wrap(SCHEDULER_NAME, MetricRegistries.instrument(metrics, delegate, SCHEDULER_NAME))); |
|
🤖 |
|
Released 0.13.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
We had no metrics on number of pending requests
After this PR
==COMMIT_MSG==
We produce metrics about requests that are going to be retried
==COMMIT_MSG==
Possible downsides?
This uses tritium to instrument the scheduledExecutor so the metric names won't be the best