Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use docker compose v2 by default everywhere #744

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Use docker compose v2 by default everywhere #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74e3424
Use docker compose v2 by default everywhere
pkoenig10 Feb 9, 2024
099d99e
Add generated changelog entries
svc-changelog Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/@unreleased/pr-744.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
type: fix
fix:
description: Use Docker Compose v2 by default when constructing a `DockerComposeExecutable`
explicitly.
links:
- https://github.com/palantir/docker-compose-rule/pull/744
2 changes: 1 addition & 1 deletion ...ule-core/src/main/java/com/palantir/docker/compose/execution/DockerComposeExecutable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ protected List<String> dockerComposePath() {

@Value.Default
public boolean useDockerComposeV2() {
return false;
return true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely need changelog for a change like this.

Copy link
Member Author

@pkoenig10 pkoenig10 Feb 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already did this intentionally in #729. We just forgot to also change the default here (these classes are structured a bit weird).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh, I still think it's useful for every human authored change to have changelog, it really helps when builds break and you can quickly see what happened.

}

@Override
Expand Down