Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SetRedirectURI option #177

Merged
merged 4 commits into from
Aug 29, 2022

Conversation

steebchen
Copy link
Contributor

@steebchen steebchen commented Aug 28, 2022

fix #176

@palantirtech
Copy link
Member

Thanks for your interest in palantir/go-githubapp, @steebchen! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Member

@bluekeyes bluekeyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One minor suggestion on the method name and doc comment, but otherwise this looks good.

oauth2/handler.go Outdated Show resolved Hide resolved
steebchen and others added 2 commits August 29, 2022 18:45
Co-authored-by: Billy Keyes <bluekeyes@gmail.com>
@bluekeyes bluekeyes merged commit 409e16b into palantir:develop Aug 29, 2022
@steebchen
Copy link
Contributor Author

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure redirect_uri for token request
3 participants