add a caching implementation for InstallationsService #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluekeyes
reviewed
Jun 27, 2023
There was a problem hiding this comment.
Code looks good and I think this makes sense to add here. As I mentioned in Slack, it's probably worth considering a time-based cache instead of an LRU cache, since that should fix the "wrong ID" problem in practice. I usually use patrickm/go-cache for situations like this, but there might be other libraries worth trying.
nvelat
force-pushed
the
nv/caching-installs
branch
from
f65ba91
to
0368a47
Compare
|
Good suggestion! Switched to a time based cache implementation |
bluekeyes
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When querying repository info many times in succession, it is useful to cache results about the app installation in order to reduce API requests to github. This PR adds a
CachingInstallationsServicewhich uses a TTL based cache to store results about app installation info with regards to repositories or owners.