Promote two error-prone checks to error (#758)

error-prone now detects `Duration#getNanos` mistakes and bans URL in equals methods
palantir · Aug 19, 2019 · 72b701d · 72b701d
1 parent 24bbd6c
commit 72b701d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/changelog/@unreleased/pr-758.v2.yml b/changelog/@unreleased/pr-758.v2.yml
@@ -0,0 +1,6 @@
+type: improvement
+improvement:
+  description: error-prone now detects `Duration#getNanos` mistakes and bans URL in
+    equals methods
+  links:
+  - https://github.com/palantir/gradle-baseline/pull/758
diff --git a/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java b/gradle-baseline-java/src/main/groovy/com/palantir/baseline/plugins/BaselineErrorProne.java
@@ -97,6 +97,8 @@ public void apply(Project project) {
                             errorProneOptions.check("EqualsIncompatibleType", CheckSeverity.ERROR);
                             errorProneOptions.check("StreamResourceLeak", CheckSeverity.ERROR);
                             errorProneOptions.check("InputStreamSlowMultibyteRead", CheckSeverity.ERROR);
+                            errorProneOptions.check("JavaDurationGetSecondsGetNano", CheckSeverity.ERROR);
+                            errorProneOptions.check("URLEqualsHashCode", CheckSeverity.ERROR);
 
                             if (jdkVersion.compareTo(JavaVersion.toVersion("12.0.1")) >= 0) {
                                 // Errorprone isn't officially compatible with Java12, but in practise everything