Exclude Java 9 module-info.java #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
raiju
commented
Nov 5, 2019
| @@ -53,6 +53,9 @@ | |||
| <property name="optional" value="true"/> | |||
| </module> | |||
| <module name="SuppressWarningsFilter"/> <!-- baseline-gradle: README.md --> | |||
| <module name="BeforeExecutionExclusionFileFilter"> | |||
| <property name="fileNamePattern" value="module\-info\.java$"/> | |||
| </module> | |||
There was a problem hiding this comment.
|
Looks plausible to me 👍 - have you tried this locally and seen |
iamdanfox
approved these changes
Nov 5, 2019
|
Yes, I've already made this change locally, which fixed CI. |
This was referenced Nov 7, 2019
This was referenced Nov 7, 2019
This was referenced Nov 22, 2019
This was referenced Nov 29, 2019
This was referenced Dec 16, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Running checkstyle on repositories with Java 9 modules fails
After this PR
==COMMIT_MSG==
Ignore module-info.java files to support projects with Jigsaw.
==COMMIT_MSG==
Possible downsides?