Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop RedundantModifier to SUGGESTION and FinalClass to WARNING #1028

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

carterkozak
Copy link
Contributor

Before this PR

After this PR

==COMMIT_MSG==
Drop RedundantModifier to SUGGESTION and FinalClass to WARNING

These checks don't imply bugs, and automation will fix failing cases automatically, so it's not necessary to block compilation.
FinalClass moved to warning rather than suggestion because there are a few edge cases (e.g. dependent projects using mockito without inline mock maker) where releases can run into issues if the bots don't fix findings in time.
==COMMIT_MSG==

Possible downsides?

Code on develop may have issues detected, but not fixed.

Based on comments from @iamdanfox.

@changelog-app
Copy link

changelog-app bot commented Nov 6, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Drop RedundantModifier to SUGGESTION and FinalClass to WARNING

These checks don't imply bugs, and automation will fix failing cases automatically, so it's not necessary to block compilation.
FinalClass moved to warning rather than suggestion because there are a few edge cases (e.g. dependent projects using mockito without inline mock maker) where releases can run into issues if the bots don't fix findings in time.

Check the box to generate changelog(s)

  • Generate changelog entry

@carterkozak
Copy link
Contributor Author

bulldozer?

@bulldozer-bot bulldozer-bot bot merged commit cd809c9 into develop Nov 7, 2019
@bulldozer-bot bulldozer-bot bot deleted the ckozak/redundant_modifier_SUGGESTION branch November 7, 2019 15:13
This was referenced Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants