Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refaster rule to remove unnecessary supplier creation #1059

Merged
merged 3 commits into from
Nov 20, 2019
Merged

Refaster rule to remove unnecessary supplier creation #1059

merged 3 commits into from
Nov 20, 2019

Conversation

carterkozak
Copy link
Contributor 

- foo.withSupplier(() -> supplier.get());
+ foo.withSupplier(supplier);

After this PR

==COMMIT_MSG==
Refaster rule to remove unnecessary supplier creation
==COMMIT_MSG==

@changelog-app
Copy link

changelog-app bot commented Nov 20, 2019 •
edited by carterkozak
Loading

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Refaster rule to remove unnecessary supplier creation

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit 686d71f into develop Nov 20, 2019
@bulldozer-bot bulldozer-bot bot deleted the ckozak/simplify_suppliers branch November 20, 2019 18:25
This was referenced Nov 20, 2019
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Closed
Merged
This was referenced Nov 20, 2019
Merged
Closed
carterkozak added a commit that referenced this pull request Nov 21, 2019
@carterkozak
Revert "Refaster rule to remove unnecessary supplier creation (#1059)"
1206042 
The refaster rule breaks the common pattern:
`Suppliers.memoize(supplier::get)`.

This reverts commit 686d71f.
@carterkozak carterkozak mentioned this pull request Nov 21, 2019
Merged
bulldozer-bot bot pushed a commit that referenced this pull request Nov 21, 2019
@carterkozak @bulldozer-bot
Revert "Refaster rule to remove unnecessary supplier creation (#1059)" (
a6dca4a 
#1063)

Revert "Refaster rule to remove unnecessary supplier creation (#1059)"
The refaster rule breaks the common pattern:
`Suppliers.memoize(supplier::get)`.
This was referenced Nov 22, 2019
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Closed
This was referenced Nov 29, 2019
Closed
Closed
This was referenced Dec 16, 2019
Closed
Merged
Closed
@svc-excavator-bot svc-excavator-bot mentioned this pull request Jan 6, 2020
Merged
This was referenced Jan 20, 2020
Merged
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferozco ferozco ferozco approved these changes

@iamdanfox iamdanfox Awaiting requested review from iamdanfox

Assignees
No one assigned
Labels
merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carterkozak @ferozco