Error prone AssertjPrimitiveComparison for primitive comparisons
#1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer using AssertJ fluent comparisons over logic in an assertThat statement for better failure output. assertThat(a == b).isTrue() failures report 'expected true' where assertThat(a).isEqualTo(b) provides the expected and actual values. This check replaces several refaster rules in order to provide a more concise, more accurate implementation.
Generate changelog in
|
iamdanfox
reviewed
Dec 2, 2019
| import javax.lang.model.type.TypeKind; | ||
|
|
||
|
|
||
| final class AssertjSingleAssertMatcher { |
There was a problem hiding this comment.
👍 I like having this separated out, I imagine there will be a lot more checks that can benefit from this
|
Also nice to be able to delete so many refasters in one go! |
|
Released 2.37.0 |
This was referenced Dec 2, 2019
This was referenced Dec 2, 2019
This was referenced Dec 16, 2019
This was referenced Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check replaces several refaster rules in order to provide a
more concise, more accurate implementation.
This check supports boxed types and mixed primitive types, in addition to full support for comparisons across all primitives.
==COMMIT_MSG==
Error prone
AssertjPrimitiveComparisonfor primitive comparisonsPrefer using AssertJ fluent comparisons over logic in an assertThat
statement for better failure output. assertThat(a == b).isTrue()
failures report 'expected true' where assertThat(a).isEqualTo(b)
provides the expected and actual values.
==COMMIT_MSG==
Possible downsides?
This check assumes the left side of a binary expression is the 'actual' value and the right side is 'expected'. This may not always be the case, but either way the resulting code will provide more actionable output on failure.