Disable ThrowSpecificty and CatchSpecificity fixes by default #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can reenable these once we have scala detection. Scala code throws checked exceptions without declaring them.
Generate changelog in
|
iamdanfox
approved these changes
Dec 6, 2019
|
dozer? |
|
Released 2.40.2 |
This was referenced Dec 6, 2019
This was referenced Dec 6, 2019
This was referenced Dec 16, 2019
This was referenced Jan 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can reenable these once we have scala detection. Scala code
throws checked exceptions without declaring them.
Before this PR
Code which interacts with scala stops catching checked exceptions because they aren't declared.
After this PR
==COMMIT_MSG==
Disable ThrowSpecificty and CatchSpecificity fixes by default
==COMMIT_MSG==
Possible downsides?
Note:calling these out in the compiler logs until we implement scala detection.