Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-default errorprone fixes to be applied from the command line #1109

Merged
merged 2 commits into from
Dec 10, 2019

Conversation

carterkozak
Copy link
Contributor

Before this PR

In an internal project we have used a similar flag to test refactors
prior to rollout, and I have wished that it was available to help
with Assertj rollout to avoid temporarily modifying gradle
configurations.

After this PR

==COMMIT_MSG==
You may apply specific error-prone refactors including those which are
not enabled by default by providing a comma delimited list of check
names to the -PerrorProneApply option.
==COMMIT_MSG==

./gradlew compileJava compileTestJava -PerrorProneApply=PreferAssertj

You may apply specific error-prone refactors including those which are
not enabled by default by providing a comma delimited list of check
names to the `-PerrorProneApply` option.

```bash
./gradlew compileJava compileTestJava -PerrorProneApply=PreferAssertj
```

In an interal project we have used a similar flag to test refactors
prior to rollout, and I have wished that it was available to help
with Assertj rollout to avoid temporarily modifying gradle
configurations.
@changelog-app
Copy link

changelog-app bot commented Dec 10, 2019

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

You may apply specific error-prone refactors including those which are
not enabled by default by providing a comma delimited list of check
names to the -PerrorProneApply option.

Check the box to generate changelog(s)

  • Generate changelog entry

Copy link
Contributor

@iamdanfox iamdanfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hell yes

@bulldozer-bot bulldozer-bot bot merged commit fd4fc07 into develop Dec 10, 2019
@bulldozer-bot bulldozer-bot bot deleted the ckozak/errorprone_apply branch December 10, 2019 19:00
@ferozco
Copy link
Contributor

ferozco commented Dec 10, 2019

👍

This was referenced Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants