Add an ErrorProne check for raw types #1197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
|
I'm supportive of this. Have we run it on a large repo to make sure that it doesn't cause any unexpected breaks? Also the changelog message should be a one-line sentence explaining what you're adding, just "Add an ErrorProne check for raw types" should be enough |
carterkozak
reviewed
Jan 31, 2020
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/RawTypes.java
Outdated
Show resolved
Hide resolved
...eline-java/src/main/groovy/com/palantir/baseline/extensions/BaselineErrorProneExtension.java
Outdated
Show resolved
Hide resolved
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/RawTypes.java
Outdated
Show resolved
Hide resolved
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/RawTypes.java
Outdated
Show resolved
Hide resolved
|
Supportive of this check as well, thanks for putting it together @AlexLandau :-) |
|
@dansanduleac Yes, I've been testing this against the big monorepo. Thanks for taking care of the changelog. @carterkozak Thanks for the suggestions! |
|
lgtm, thanks! 👍 |
|
Released 3.2.0 |
This was referenced Feb 1, 2020
This was referenced Feb 1, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an ErrorProne check that fails when it detects raw types. Currently, javac has a built-in warning type for this, but it's not as flexible as ErrorProne; for example, you can't fail on raw-types errors without also failing on deprecation warnings, and you can't add exemptions for generated code.
Upstream ErrorProne doesn't seem to have any check for this or requests for such a check, beyond this issue: google/error-prone#253
For @SuppressWarnings, the check respects "rawtypes", which is already used by javac and Eclipse.
The current level is "warning"; feel free to change that.
I added the check to the BaselineErrorProneExtension due to seeing it in another PR adding a check.