License replacement attempts to preserve existing year info #1227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
iamdanfox
commented
Feb 10, 2020
| boolean existingHeaderContainsYear = yearInfo.find(); | ||
| String year = existingHeaderContainsYear | ||
| ? yearInfo.group(0) | ||
| : String.valueOf(YearMonth.now().getYear()); |
There was a problem hiding this comment.
this line is really the money.
the rest of the PR is mainly just me deleting indirection that doesn't seem necessary now that we're not working around spotless' API
ferozco
approved these changes
Feb 10, 2020
|
Released 3.4.1 |
|
Thanks @iamdanfox! |
This was referenced Feb 11, 2020
This was referenced Feb 11, 2020
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
@tusharnarayan got a PR to upgrade baseline on his project and it nuked all his existing license (which were pretty bonkers anyway) and replaced them with 2020 ones. This upsets legal, who prefer to preserve the original creation date of files where possible.
After this PR
==COMMIT_MSG==
Auto-fixing license headers will attempt to preserve the existing year of creation.
==COMMIT_MSG==
I predict this will be incredibly useful when we want to open source an internal project, because we should be able to just swap out the license template it .baseline/copyright and then run
./gradlew format.Confirming I ran this on tushar's project and it did the right thing.
Possible downsides?