Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't trim license template lines #1228

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Conversation

iamdanfox
Copy link
Contributor

@iamdanfox iamdanfox commented Feb 11, 2020

Before this PR

PRs were being made to helpfully chop the whitespace off the front of lines:

- *     http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0

We don't want this as the authoritative license has the whitespace prefix:

After this PR

==COMMIT_MSG==
Copyright header enforcement now includes any leading and trailing whitespace on lines
==COMMIT_MSG==

Possible downsides?

  • trailing whitespace is generally considered a bad thing. If a template has trailing whitespace, it'll be propagated everywhere. solution is to just not have trailing whitespace in your templates I think.

@changelog-app
Copy link

changelog-app bot commented Feb 11, 2020

Generate changelog in changelog/@unreleased

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Copyright header enforcement now includes any leading and trailing whitespace on lines

Check the box to generate changelog(s)

  • Generate changelog entry

@bulldozer-bot bulldozer-bot bot merged commit c3cec69 into develop Feb 11, 2020
@bulldozer-bot bulldozer-bot bot deleted the dfox/dont-trim-template-lines branch February 11, 2020 10:55
@svc-autorelease
Copy link
Collaborator

Released 3.4.2

This was referenced Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants