Disable catch specificity by default #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
fawind
approved these changes
Mar 6, 2020
carterkozak
approved these changes
Mar 6, 2020
|
Released 3.8.0 |
|
Should we also disable |
|
If it's causing noise, feel free to push a PR to disable it. It has been helpful in a number of places but I don't think it buys us a lot until we're ready to start working on checks for proper InterruptedException handling, which won't be for a while. |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
CatchSpecificitydid not fail builds by default, but did result in a lot of output at compile time making it hard to quickly see the errors.After this PR
==COMMIT_MSG==
Disable
CatchSpecificityerrorprone check by default==COMMIT_MSG==
Possible downsides?