Remove SwitchStatementDefaultCase error-prone check

[pkoenig10]

Fixes #499
Fixes #541
Fixes #580

Before this PR

Baseline provides a SwitchStatementDefaultCase error-prone check.

After this PR

Baseline does not provide a SwitchStatementDefaultCase error-prone check.

I added this back in #481 with a very narrow focus on enums used in APIs. However there a many valid uses of default case in switch statements outside the narrow scope of interacting with an API.

We've ended disabling this check on many of our internal repos. And for repos that haven't disabled this check, having it at SUGGESTION results in a noisy compiler output.

A number of other people have experience friction with this check, see the issues linked above.

The built-in error-prone switch statement checks should be sufficient for our uses.

[changelog-app]

Generate changelog in changelog/@unreleased

Type

• Feature
• Improvement
• Fix
• Break
• Deprecation
• Manual task
• Migration

Description

Baseline no longer provides a SwitchStatementDefaultCase error-prone check.

Check the box to generate changelog(s)

• Generate changelog entry

[stale]

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

[pkoenig10]

@iamdanfox @ferozco any thoughts on this?

[stale]

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

[pkoenig10]

@iamdanfox @ferozco another gentle ping

[iamdanfox]

Ok so we're now just relying on product teams to know to avoid using default when they want to have exhaustiveness validated?

[pkoenig10]

Yes.

This check was only ever a SUGGESTION, so it was never a hard failure and relied on noticing the message in the compiler output.

[stale]

This PR has been automatically marked as stale because it has not been touched in the last 14 days. If you'd like to keep it open, please leave a comment or add the 'long-lived' label, otherwise it'll be closed in 7 days.

[pkoenig10]

@iamdanfox any other concerns here?

[svc-autorelease]

Released 3.12.0