Stop IntelliJ suggesting commonly shaded packages #1350
Conversation
Generate changelog in
|
| <name>org.gradle.internal.impldep</name> | ||
| <name>autovalue.shaded</name> | ||
| <name>org.inferred.freebuilder.shaded</name> | ||
| </excluded-names> |
There was a problem hiding this comment.
@ilyanep If memory serves you had a list of packages that are helpful to exclude, is there anything missing here?
There was a problem hiding this comment.
@carterkozak My full list is:
- com.palantir.shaded
- com.sun.javafx.collections
- com.sun.tools.javac.util
- com.sun.xml.internal
- de.intarsys
- io.vavr
- jersey.repackaged
- org.apache.poi.ss.formula
- org.aspectj.lang.annotation
- org.codehaus.jackson
- org.jooq.Exception.IOException
- shaded.com.palantir
- shaded.es244
- shaded.es6x
Copied from what I have configured right now, though not sure how many of those are generally applicable for baseline. Hope that's helpful!
|
Nice this is very slick! I really appreciate it for gradle plugin development |
…alantir/gradle-baseline into callumr/stop-suggesting-shaded-classes
|
👍 @CRogers did you test this out locally to make sure the plumbing is all set? |
|
Released 3.14.1 |
|
wrecked, I approved at the same time you added the labels :( |
|
Race conditions! Yep, I tested locally on a couple of projects (this "after" screenshot was from one of them) |
Before this PR
Jars commonly contain shaded dependencies - you should never use them, but they end up polluting your autocomplete suggestions:
Internally, someone was confused why their code wasn't compiling because they were using a shaded version of an interface that was generated by
gradle-shadow-jar.After this PR
==COMMIT_MSG==
Classes in common shaded packages are no longer for autocompletion/auto-import recommended by IntelliJ.
==COMMIT_MSG==
Possible downsides?
I can't really think of any. It's only "bad" if people want to use this shaded classes (they shouldn't) and would perhaps be annoying they're not suggested? Even then, this just stops suggestions, you can still find them/use them: