Enable PreferCollectionConstructors by default #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate changelog in
|
ferozco
reviewed
Jun 3, 2020
| @@ -57,7 +57,7 @@ | |||
| name = "CatchSpecificity", | |||
| link = "https://github.com/palantir/gradle-baseline#baseline-error-prone-checks", | |||
| linkType = BugPattern.LinkType.CUSTOM, | |||
| severity = BugPattern.SeverityLevel.SUGGESTION, | |||
| severity = BugPattern.SeverityLevel.WARNING, | |||
There was a problem hiding this comment.
I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?
There was a problem hiding this comment.
Looks like we just wanted to validate that it did the right thing and then planned to increase the severity.
#941 (comment)
There was a problem hiding this comment.
I think we wanted to roll out the refactors for a while before adding the requirement to avoid friction.
|
Adding do not merge, while waiting for a response to my question. Otherwise LGTM 👍 . Thanks @pkoenig10 |
pkoenig10
force-pushed
the
pkoenig/collectionConstructors
branch
from
a4dbf2d
to
840ad40
Compare
pkoenig10
force-pushed
the
pkoenig/collectionConstructors
branch
from
840ad40
to
01d9371
Compare
|
Released 3.23.0 |
This was referenced Jun 22, 2021
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This excavator has been out for a while so making this a
WARNINGshould not result in too much additional code churn.Also update severity on some checks I missed in #1380.